Supported check #388
Merged
Supported check #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors instead of defining another one
This is to ensure the code within this provider only executes on dells
This is to ensure the Openbmc provider executes code only on hardware identified to be Openbmc
providers/dell/idrac.go
Outdated
| @@ -204,21 +205,37 @@ func (c *Conn) Compatible(ctx context.Context) bool { | |||
|
|
|||
| // PowerStateGet gets the power state of a BMC machine | |||
| func (c *Conn) PowerStateGet(ctx context.Context) (state string, err error) { | |||
| if err := c.deviceSupported(ctx); err != nil { | |||
There was a problem hiding this comment.
This provider already has this check in Open. I'm not following the value add for putting this in all these individual methods. As far as I can tell deviceSupported doesnt do any method specific checks either.
There was a problem hiding this comment.
Thanks for pointing that out, you're right the dell, openbmc checks were redundant.
I noticed dell showing up as a successfulProvider on another device - which was odd, but I haven't been able to reproduce the case, and theres no way it should end up in there. Changes reverted.
jacobweinstock
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Verify hardware support in each Redfish based provider.
This is to ensure each of these hardware vendor specific providers will not proceed to execute methods unless the hardware is identified as supported.
Checklist
The HW vendor this change applies to (if applicable)