Panic recovery #151
Merged
Panic recovery #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the task is not left in an active state if the task handlers panic. Going ahead I'd like to move this into the controller library, for now this can be here.
until a bmclib release is cut
DoctorVin
previously approved these changes
Apr 17, 2024
| "available": strings.Join(b.availableProviders, ","), | ||
| "caller": funcName, | ||
| }, | ||
| ).Trace("required provider not in available list") |
There was a problem hiding this comment.
Is it appropriate for this to just be at TRACE? It feels more serious.
There was a problem hiding this comment.
since this tends to add a lot of noise its a Trace. I'll look at if it can be turned up - in most cases the actual error would bubble up, this is mainly for debugging.
DoctorVin
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do