Fix session leak in Dell provider: #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 44.93% 45.05% +0.12%
==========================================
Files 54 54
Lines 4206 4208 +2
==========================================
+ Hits 1890 1896 +6
+ Misses 2108 2104 -4
Partials 208 208
☔ View full report in Codecov by Sentry. |
This was leaving open sessions in non Dell machines. Closed sessions when the Dell Open function returns error after successfully opening. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-dell-session-leak
branch
3 times, most recently
from
1dde313 to
e5a79f8
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
fix-dell-session-leak
branch
from
e5a79f8 to
7e0fd36
Compare
chrisdoherty4
previously approved these changes
Oct 17, 2023
providers/dell/idrac_test.go
Outdated
| @@ -12,6 +13,7 @@ import ( | |||
| "os" | |||
| "testing" | |||
|
|
|||
| bmclibErrs "github.com/bmc-toolbox/bmclib/v2/errors" | |||
There was a problem hiding this comment.
bmclibErrs -> bmcliberrs
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added a commit
to jacobweinstock/eks-anywhere
that referenced
this pull request
Dec 6, 2023
New version has a session leak fix. bmc-toolbox/bmclib#356 Signed-off-by: Jacob Weinstock <[email protected]>
eks-distro-bot
pushed a commit
to aws/eks-anywhere
that referenced
this pull request
Dec 6, 2023
* Update bmclib library: New version has a session leak fix. bmc-toolbox/bmclib#356 Signed-off-by: Jacob Weinstock <[email protected]> * For some reason i need to update this: I dont understand how its related to my top level go.mod changes. Signed-off-by: Jacob Weinstock <[email protected]> --------- Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
This was leaving open sessions in non Dell machines. Closed sessions when the Dell Open function returns error after successfully opening.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes