Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bmclib library: #7135

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

jacobweinstock
Copy link
Member

Issue #, if available:

Description of changes:
New version has a session leak fix.
bmc-toolbox/bmclib#356

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

New version has a session leak fix.
bmc-toolbox/bmclib#356

Signed-off-by: Jacob Weinstock <[email protected]>
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fec15e4) 71.58% compared to head (bad7a67) 71.58%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7135   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files         545      545           
  Lines       42358    42358           
=======================================
  Hits        30323    30323           
  Misses      10343    10343           
  Partials     1692     1692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock
Copy link
Member Author

/test eks-anywhere-presubmit

I dont understand how its related to my
top level go.mod changes.

Signed-off-by: Jacob Weinstock <[email protected]>
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2023
@jacobweinstock
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 28c8c58 into aws:main Dec 6, 2023
14 checks passed
@jacobweinstock jacobweinstock deleted the update-bmclib branch December 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants