Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish disable Etag match header #353

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Redfish disable Etag match header #353

merged 2 commits into from
Sep 22, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Work around for (crappy) vendor implementations where the If-Match
header does not work - even with '*' as the value, requests are
incorrectly denied with an ETag mismatch error.

depends on stmcginnis/gofish#277

Checklist

  • Tests added
  • Similar commits squashed

…eaders

Work around for (crappy) vendor implementations where the If-Match
header does not work - even with '*' as the value, requests are
incorrectly denied with an ETag mismatch error.

depends on stmcginnis/gofish#277
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.04% ⚠️

Comparison is base (44c2961) 44.56% compared to head (93480d6) 44.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   44.56%   44.53%   -0.04%     
==========================================
  Files          51       51              
  Lines        4104     4116      +12     
==========================================
+ Hits         1829     1833       +4     
- Misses       2065     2073       +8     
  Partials      210      210              
Files Changed Coverage Δ
internal/redfishwrapper/power.go 0.00% <0.00%> (ø)
providers/redfish/redfish.go 25.53% <25.00%> (-0.03%) ⬇️
internal/redfishwrapper/client.go 22.34% <100.00%> (+2.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit 1f97b35 into main Sep 22, 2023
@mergify mergify bot deleted the redfish-etag branch September 22, 2023 07:32
@joelrebel joelrebel mentioned this pull request Sep 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants