Client opts fixes #354
Merged
Client opts fixes #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 44.68% 44.96% +0.28%
==========================================
Files 54 54
Lines 4178 4203 +25
==========================================
+ Hits 1867 1890 +23
- Misses 2101 2105 +4
+ Partials 210 208 -2
☔ View full report in Codecov by Sentry. |
joelrebel
force-pushed
the
client-opts-fixes
branch
from
067d223 to
e69320e
Compare
jacobweinstock
requested changes
Sep 25, 2023
client.go
Outdated
| } | ||
|
|
||
| // register ASRR vendorapi provider | ||
| func (c *Client) registerASRRProvider() error { |
There was a problem hiding this comment.
this func will never return an error. i would suggest not having any return value.
There was a problem hiding this comment.
That was mainly keeping the pattern from the above function since I was looking into if these could be turned into an interface method which providers implement to register themselves so this can be moved into each provider.
I can remove the extra error returns for now.
jacobweinstock
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes