Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish provider to support unstructured http push uploads #346

Merged
merged 16 commits into from
Sep 19, 2023

Conversation

joelrebel
Copy link
Member

What does this PR implement/change/remove?

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 50.62% and project coverage change: +0.08% 🎉

Comparison is base (b1092ac) 44.43% compared to head (0a859e1) 44.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   44.43%   44.52%   +0.08%     
==========================================
  Files          50       51       +1     
  Lines        4015     4108      +93     
==========================================
+ Hits         1784     1829      +45     
- Misses       2027     2068      +41     
- Partials      204      211       +7     
Files Changed Coverage Δ
internal/redfishwrapper/client.go 19.78% <0.00%> (-0.45%) ⬇️
providers/redfish/tasks.go 32.94% <32.91%> (-36.51%) ⬇️
providers/redfish/firmware.go 53.57% <52.27%> (+7.25%) ⬆️
providers/redfish/tasks_dell.go 69.44% <69.44%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ofaurax ofaurax force-pushed the redfish-firmware-installs branch 2 times, most recently from aecee06 to f096534 Compare September 4, 2023 16:12
@ofaurax ofaurax marked this pull request as ready for review September 4, 2023 16:40
@ofaurax
Copy link
Collaborator

ofaurax commented Sep 4, 2023

@joelrebel please review, it seems you can't be the reviewer of your own PR, but I need a look to my code...

@joelrebel joelrebel changed the base branch from main to redfish-stream-uploads September 5, 2023 08:26
providers/redfish/firmware.go Show resolved Hide resolved
providers/redfish/firmware.go Show resolved Hide resolved
providers/redfish/tasks.go Outdated Show resolved Hide resolved
providers/redfish/firmware.go Outdated Show resolved Hide resolved
providers/redfish/firmware.go Outdated Show resolved Hide resolved
providers/redfish/firmware.go Outdated Show resolved Hide resolved
providers/redfish/firmware_test.go Outdated Show resolved Hide resolved
@ofaurax ofaurax force-pushed the redfish-firmware-installs branch 2 times, most recently from ea4b418 to 133e324 Compare September 5, 2023 15:48
@ofaurax ofaurax mentioned this pull request Sep 5, 2023
2 tasks
Base automatically changed from redfish-stream-uploads to main September 11, 2023 14:11
@ofaurax ofaurax force-pushed the redfish-firmware-installs branch 4 times, most recently from 9f2672e to 9c3621b Compare September 13, 2023 12:26
Copy link
Member Author

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here, left a few minor suggestions

providers/redfish/firmware.go Outdated Show resolved Hide resolved
constants/constants.go Outdated Show resolved Hide resolved
providers/redfish/firmware_test.go Outdated Show resolved Hide resolved
providers/redfish/firmware.go Outdated Show resolved Hide resolved
providers/redfish/firmware.go Outdated Show resolved Hide resolved
providers/redfish/tasks.go Show resolved Hide resolved
@ofaurax ofaurax force-pushed the redfish-firmware-installs branch from 9c3621b to cd90658 Compare September 14, 2023 08:35
@ofaurax ofaurax force-pushed the redfish-firmware-installs branch from 9fe45af to 85bb93e Compare September 14, 2023 08:56
ofaurax
ofaurax previously approved these changes Sep 14, 2023
@ofaurax ofaurax force-pushed the redfish-firmware-installs branch from 85bb93e to 4dec4c6 Compare September 14, 2023 09:07
@ofaurax ofaurax changed the title Redfish provider to support unstructured http push uploads [WIP] Redfish provider to support unstructured http push uploads Sep 14, 2023
@joelrebel joelrebel mentioned this pull request Sep 14, 2023
2 tasks
@ofaurax ofaurax merged commit c402b01 into main Sep 19, 2023
7 checks passed
@ofaurax ofaurax deleted the redfish-firmware-installs branch September 19, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants