Use correct type for multipartHTTP update

bmc-toolbox · Sep 13, 2023 · 9f2672e · 9f2672e
1 parent a9eae65
commit 9f2672e
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/providers/redfish/firmware.go b/providers/redfish/firmware.go
@@ -105,7 +105,7 @@ func (c *Conn) FirmwareInstall(ctx context.Context, component, applyAt string, f
 	switch installMethod {
 	case multipartHttpUpload:
 		var uploadErr error
-		resp, uploadErr = c.multipartHTTPUpload(ctx, installURI, applyAt, reader)
+		resp, uploadErr = c.multipartHTTPUpload(ctx, installURI, applyAt, updateFile)
 		if uploadErr != nil {
 			return "", errors.Wrap(bmclibErrs.ErrFirmwareInstall, uploadErr.Error())
 		}
@@ -160,7 +160,7 @@ type multipartPayload struct {
 	updateFile       *os.File
 }
 
-func (c *Conn) multipartHTTPUpload(ctx context.Context, url, applyAt string, update io.Reader) (*http.Response, error) {
+func (c *Conn) multipartHTTPUpload(ctx context.Context, url, applyAt string, update *os.File) (*http.Response, error) {
 	if url == "" {
 		return nil, fmt.Errorf("unable to execute request, no target provided")
 	}
@@ -180,9 +180,9 @@ func (c *Conn) multipartHTTPUpload(ctx context.Context, url, applyAt string, upd
 	}
 
 	// payload ordered in the format it ends up in the multipart form
-	payload := []map[string]io.Reader{
-		{"UpdateParameters": bytes.NewReader(parameters)},
-		{"UpdateFile": update},
+	payload := &multipartPayload{
+		updateParameters: []byte(parameters),
+		updateFile: update,
 	}
 
 	return c.runRequestWithMultipartPayload(url, payload)