Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Refactor Test Plan #112

Merged
merged 8 commits into from
Jan 17, 2023
Merged

[Chore] Refactor Test Plan #112

merged 8 commits into from
Jan 17, 2023

Conversation

blyscuit
Copy link
Owner

Duplicate of #108

What happened

Remove UITests target from test plan.

Reduce error on CI/CD resulting from UITests target, speed up development.

Insight

  • Redefined tester to show failing line in report.
  • Replace UITests coverage by new KIF test.
  • Add fail screenshots upload to workflows for debugging.
  • Add test AA_AppLoadSpec in the first slot because GH Actions is slow to load other test and randomly fail it.
    • Ignore AA_AppLoadSpec error since it repeats other test.
    • Retry tests solves this error but Danger-Xcode doesn't work well with repeat mode yet.

Proof Of Work

Test passes.

Old coverage:
Screen Shot 2023-01-13 at 12 43 20

New coverage:
Screen Shot 2023-01-13 at 12 43 26

@blyscuit blyscuit added this to the 0.5.0 milestone Jan 17, 2023
@blyscuit blyscuit self-assigned this Jan 17, 2023
@blyscuit blyscuit changed the base branch from develop to feature/#43-refresh-token-backend January 17, 2023 02:38
@github-actions
Copy link

5 Warnings
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - The constructor(getCurrentDateUseCase: GetCurrentDateUseCase, getProfileUseCase: GetProfileUseCase, getAppVersionUseCase: GetAppVersionUseCase, surveyListUseCase: SurveyListUseCase, dateTimeFormatter: DateTimeFormatter) has too many parameters. The current threshold is set to 5.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - Class 'SurveySelectionViewModel' with '13' functions detected. Defined threshold inside classes is set to '10'
⚠️ shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/data/repository/AuthenticationRepositoryTest.kt#L23 - Class 'AuthenticationRepositoryTest' with '10' functions detected. Defined threshold inside classes is set to '10'
⚠️ shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt#L34 - Class SurveySelectionViewModelTest is too large. Consider splitting it into smaller pieces.

🧛 shared Code Coverage: 82.61%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

.gitignore
AA_AppLoadSpec.swift
AccountScreen.swift
AccountSpec.swift
CICDTests.xctestplan
Dangerfile
Fastfile
GenericScreen.swift
LoginScreen.swift
LoginView.swift
ResetPasswordSpec.swift
SurveyScreen.swift
ViewId+General.swift
ios_review_pull_request.yml
ios_sanity_full_test.yml
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

Current coverage for Survey is 87.53%

Files changed - -
LoginView.swift 95.14%

Powered by xcov

Generated by 🚫 Danger

Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@blyscuit blyscuit mentioned this pull request Jan 17, 2023
Base automatically changed from feature/#43-refresh-token-backend to develop January 17, 2023 03:46
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blyscuit blyscuit merged commit 9d74e66 into develop Jan 17, 2023
@blyscuit blyscuit deleted the chore/refactor-test-plan branch January 17, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants