Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 0.5.0 #114

Merged
merged 48 commits into from
Jan 17, 2023
Merged

Release - 0.5.0 #114

merged 48 commits into from
Jan 17, 2023

Conversation

blyscuit
Copy link
Owner

blyscuit and others added 30 commits December 30, 2022 13:15
@blyscuit
[Chore] Update iOS to 0.5.0
ba05aa4
@blyscuit
Merge pull request #104 from blyscuit/chore/bump-version-0.5.0
98a05d9 
[Chore] Bump version to 0.5.0
@blyscuit
[#21] Rebase
5f2efff
@blyscuit
[#23] Add Account side view
82e5518
@blyscuit
[#23] Add Account side view uitest
79bb596
@blyscuit
[#23] Add KIF and tests
1ddb295
@blyscuit
[#23] Add KIF and tests
18aceee
@blyscuit
[#23] Fix KIF tests
6efb585
@blyscuit
[#23] Add KIF to full test
b5b1c6a
@blyscuit
[#23] Fix naming comments.
454586f
@blyscuit
[#23] Refactor SwiftUI to sections
f66c782
@blyscuit
[#24] Logout UI integration with test
d3227a1 
[#22] Rebase fix test

[#21] Rebase

[#23] Fix KIF tests

[#23] Fix KIF tests

[#24] Logout UI integration with test
@blyscuit
[#24] Fix comments
0507a89
@blyscuit
[#24] Fix comments
e725ebb
@blyscuit
Merge pull request #67 from blyscuit/feature/#23-logout-ui
e6e3e3b 
[#23] [iOS] [UI] As a user, I can log out
@blyscuit
[#25] Add logout usecase
2566411
@blyscuit
[#25] Add logout usecase tests
66c7f21
@blyscuit
[#25] Add logout usecase tests
0f3ed3b
@blyscuit
[#25] Fix comments
c9d23e2
@blyscuit
[#24] Use logout viewmodel
59b96cf
@blyscuit
[#24] Add viewmodel unit test
805c320
@blyscuit
[#24] Add datasource unit test
5197e30
@blyscuit
[#24] Add helper for KMPCombine
fc60eba
@blyscuit
[#24] Fix build
481343a
@blyscuit
[#24] Change root view coordinator to StateObject
64f8c3d
@blyscuit
[#24] Fix comments
9adb660
@blyscuit
Merge pull request #105 from blyscuit/feature/#24-logout-ui-integration
8612426 
[#24] [iOS] [Integrate] As a user, I can log out
@blyscuit
Merge pull request #100 from blyscuit/feature/#25-logout-backend
c43ac66 
[#25] [KMM] [Backend] As a user, I can log out
@blyscuit
[#24] Fix comments
f0db01f
@blyscuit
Merge pull request #101 from blyscuit/feature/#24-logout-integration
1b7268b 
[#24] [iOS] [Integrate] As a user, I can log out, Part: ViewModel
blyscuit and others added 12 commits January 10, 2023 18:03
@blyscuit blyscuit added this to the 0.5.0 milestone Jan 17, 2023
@blyscuit blyscuit requested a review from suho as a code owner January 17, 2023 03:45
@blyscuit blyscuit self-assigned this Jan 17, 2023
@blyscuit
Merge pull request #111 from blyscuit/feature/#43-refresh-token-backend
cfbd416 
[#44] [#43] [Integrate] [Backend] As a user, I can refresh my token when it's expired
@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

8 Warnings
⚠️ Big PR
⚠️ Please remove period from end of commit subject line.
454586f
⚠️ Uh oh! AccountViewModel.kt is under 95% coverage!
⚠️ Uh oh! RefreshTokenType.kt is under 95% coverage!
⚠️ Uh oh! SurveyUiModel.kt is under 95% coverage!
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.
⚠️ shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/data/repository/AuthenticationRepositoryTest.kt#L23 - Class 'AuthenticationRepositoryTest' with '10' functions detected. Defined threshold inside classes is set to '10'
⚠️ shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt#L34 - Class SurveySelectionViewModelTest is too large. Consider splitting it into smaller pieces.

🧛 shared Code Coverage: 82.61%

Coverage of Modified Files:

File Coverage
AccountUiModel.kt 100.00%
AccountViewModel.kt 92.78%
AppInfoRepositoryImpl.kt 100.00%
AppVersion.kt 100.00%
AuthenticationRepositoryImpl.kt 100.00%
DataStore.kt 100.00%
GetAppVersionUseCase.kt 100.00%
LocalDataSource.kt 100.00%
LogOutUseCase.kt 100.00%
NetworkDataSource.kt 100.00%
Platform.kt 100.00%
RefreshTokenType.kt 57.32%
SurveySelectionViewModel.kt 96.77%
SurveyUiModel.kt 78.05%
TokenizedNetworkClient.kt 96.81%

Modified Files Not Found In Coverage Report:

.gitignore
AA_AppLoadSpec.swift
AccountScreen.swift
AccountScreen.swift
AccountSpec.swift
AccountView+DataSource.swift
AccountView.swift
AccountViewDataSourceSpec.swift
AccountViewModelTest.kt
AppCoordinator.swift
AppInfoRepository.kt
AppInfoRepositoryTest.kt
AuthenticationRepository.kt
AuthenticationRepositoryTest.kt
CICDTests.xctestplan
Constants.rb
Dangerfile
DataStoreTest.kt
DeviceInfoRepositoryTest.kt
DomainHelperModule.kt
FadePaginationView.swift
Fastfile
Font+Extensions.swift
GenericScreen.swift
GetAppVersionUseCaseTest.kt
Image+Url.swift
Info.plist
KIF+Swift.swift
KMPNative+Guaranteed.swift
LocalDataSourceTest.kt
LogOutUseCaseTest.kt
LoginScreen.swift
LoginView.swift
NetworkDataSourceTest.kt
NetworkModule.kt
Podfile
Podfile.lock
RepositoryModule.kt
ResetPassword+DataSource.swift
ResetPasswordSpec.swift
RouteCoordinator.swift
Shared+AutoMockable.swift
SplashView+DataSource.swift
Survey Staging Extended Tests.xcscheme
Survey Staging.xcscheme
Survey.xcscheme
SurveyHeaderView.swift
SurveyScreen.swift
SurveySelectionContainerView.swift
SurveySelectionSpec.swift
SurveySelectionSpec.swift
SurveySelectionView+DataSource.swift
SurveySelectionView.swift
SurveySelectionViewDataSourceSpec.swift
SurveySelectionViewModelTest.kt
TestManager.rb
TokenizedNetworkClientTest.kt
UITestLogout.kt
UseCaseModule.kt
VersionCode.kt
VersionCodeImpl.kt
VersionCodeImpl.kt
ViewId+Account.swift
ViewId+General.swift
ViewId+SurveySelection.swift
ViewId.swift
ViewModelModule.kt
XCUIApplication+.swift
ios_review_pull_request.yml
ios_sanity_full_test.yml
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

Current coverage for Survey is 87.53%

Files changed - -
KMPNative+Guaranteed.swift 70.00% ⚠️
RouteCoordinator.swift 72.73% ⚠️
ResetPassword+DataSource.swift 87.50% ✅
SurveySelectionView+DataSource.swift 88.89% ✅
SurveySelectionContainerView.swift 91.15% ✅
SplashView+DataSource.swift 91.49% ✅
LoginView.swift 95.14% ✅
FadePaginationView.swift 95.78% ✅
SurveySelectionView.swift 98.68% ✅
AccountView.swift 100.00% ✅
Font+Extensions.swift 100.00% ✅
SurveyHeaderView.swift 100.00% ✅
AppCoordinator.swift 100.00% ✅
Image+Url.swift 100.00% ✅
ViewId.swift 100.00% ✅
AccountView+DataSource.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit merged commit 4a8ef39 into main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@doannimble doannimble doannimble approved these changes

@minhnimble minhnimble minhnimble approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@edgarss edgarss Awaiting requested review from edgarss edgarss is a code owner

Assignees

@blyscuit blyscuit

Labels
type: release
Projects
KMM IC
Status: Done
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blyscuit @minhnimble @doannimble