Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: support relabelings in ServiceMonitor #148

Merged
merged 8 commits into from
Nov 11, 2024
Merged

improvement: support relabelings in ServiceMonitor #148

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
876b3f4
improvement: support relabelings in ServiceMonitor
scoof Aug 12, 2024
b07803d
fix: move metricRelabelings to correct section
scoof Aug 26, 2024
f7ab34e
Update the chart version
skamboj Sep 9, 2024
d8819d6
Fix datatype
scoof Sep 9, 2024
438c5d0
Merge branch 'master' into improvement-metricrelabelings
skamboj Nov 11, 2024
8db3d2f
Fix typo
skamboj Nov 11, 2024
41680b8
Up the app version
skamboj Nov 11, 2024
98bee8c
Merge branch 'master' into improvement-metricrelabelings
skamboj Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/goldpinger/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
name: goldpinger
appVersion: "3.10.1"
version: 1.0.0
version: 1.0.1
description: Goldpinger is a tool to help debug, troublshoot and visualize network connectivity and slowness issues.
home: https://github.com/bloomberg/goldpinger
sources:
Expand Down
4 changes: 4 additions & 0 deletions charts/goldpinger/templates/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ spec:
{{- if .Values.serviceMonitor.honorLabels }}
honorLabels: true
{{- end }}
{{- with .Values.serviceMonitor.metricRelabelings }}
metricRelabelings:
{{- toYaml . | nindent 8 }}
{{- end }}
jobLabel: name
namespaceSelector:
matchNames:
Expand Down
4 changes: 4 additions & 0 deletions charts/goldpinger/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ serviceMonitor:
# namespace: monitoring
interval: 30s
# honorLabels: true
metricRelabelings: {}
scoof marked this conversation as resolved.
Show resolved Hide resolved
# - action: drop
# source_labels: [__name__]
# regex: goldpinger_peers_response_time_s_bucket

## Custom PrometheusRule to be defined
## ref: https://github.com/coreos/prometheus-operator#customresourcedefinitions
Expand Down
Loading