improvement: support relabelings in ServiceMonitor #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-Off-By: Andreas Plesner <[email protected]>
|
Prioritize this, please. |
Signed-off-by: Andreas Plesner <[email protected]>
scoof
force-pushed
the
improvement-metricrelabelings
branch
from
0c26b59 to
b07803d
Compare
Signed-off-by: Sachin Kamboj <[email protected]>
skamboj
reviewed
Sep 9, 2024
skamboj
reviewed
Sep 9, 2024
Signed-off-by: Andreas Plesner <[email protected]>
skamboj
approved these changes
Nov 11, 2024
skamboj
force-pushed
the
improvement-metricrelabelings
branch
2 times, most recently
from
548d790 to
438c5d0
Compare
Signed-off-by: Sachin Kamboj <[email protected]>
Signed-off-by: Sachin Kamboj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added optional support for metricRelabelings
Testing performed
ServiceMonitor renders cleanly with or without relabelings