Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB-57871, MB-62230: Upgrade to zapx/[email protected] + [email protected] #2088

Merged
merged 5 commits into from
Oct 18, 2024
Merged

MB-57871, MB-62230: Upgrade to zapx/[email protected] + [email protected] #2088

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7404155
AddMany instead of Add to a bitmap
metonymic-smokey Oct 15, 2024
c9eb834
use GetCardinality()
metonymic-smokey Oct 16, 2024
a328124
added condition for no eligible docs
metonymic-smokey Oct 17, 2024
0d3d0ab
Upgrade to zapx/[email protected] and [email protected]
abhinavdangeti Oct 18, 2024
d671b93
Merge branch 'master' into pre-filter-perf
abhinavdangeti Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index/scorch/optimize_knn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (o *OptimizeVR) Finish() error {
}

eligibleLocalDocNums := make([]uint64,
eligibleVectorInternalIDs.Stats().Cardinality)
eligibleVectorInternalIDs.GetCardinality())
// get the (segment-)local document numbers
for i, docNum := range eligibleVectorInternalIDs.ToArray() {
localDocNum := o.snapshot.localDocNumFromGlobal(index,
Expand Down
9 changes: 7 additions & 2 deletions index/scorch/snapshot_index_vr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,16 @@ type IndexSnapshotVectorReader struct {
// (AND) operations. Eg. finding the eligible doc IDs present in a segment.
func (i *IndexSnapshotVectorReader) getEligibleDocIDs() *roaring.Bitmap {
res := roaring.NewBitmap()
internalDocIDs := make([]uint32, 0, len(i.eligibleDocIDs))
metonymic-smokey marked this conversation as resolved.
Show resolved Hide resolved
// converts the doc IDs to uint32 and returns
for _, eligibleDocInternalID := range i.eligibleDocIDs {
internalDocID, _ := docInternalToNumber(index.IndexInternalID(eligibleDocInternalID))
res.Add(uint32(internalDocID))
internalDocID, err := docInternalToNumber(index.IndexInternalID(eligibleDocInternalID))
if err != nil {
continue
}
internalDocIDs = append(internalDocIDs, uint32(internalDocID))
}
res.AddMany(internalDocIDs)
return res
}

Expand Down
Loading