Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-57871, MB-62230: Upgrade to zapx/[email protected] + [email protected] #2088

Merged
merged 5 commits into from
Oct 18, 2024
Merged

MB-57871, MB-62230: Upgrade to zapx/[email protected] + [email protected] #2088

merged 5 commits into from
Oct 18, 2024

Conversation

metonymic-smokey
Copy link
Member

@metonymic-smokey metonymic-smokey commented Oct 16, 2024 •
edited by abhinavdangeti
Loading

MB-62230:

  • Add elements to bitmap in a batch.
  • 5f8f0f0 Aditi Ahuja | MB-62230 - Pre-filtering performance optimisations

MB-57871:

  • 7bab2f9 Abhi Dangeti | MB-57871: One more nil check before dereferencing postings
  • bf971e6 Abhi Dangeti | Add nil pointer checks for postings before dereference
  • 9a80f5f Abhi Dangeti | One more case for zero chunk size / mode
  • 0c6f397 Mohd Shaad Khan | Handle zero chunk size

@abhinavdangeti abhinavdangeti added this to the v2.4.3 milestone Oct 16, 2024
abhinavdangeti
abhinavdangeti previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@abhinavdangeti abhinavdangeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this when we've tags ready for go-faiss and zapx.

@abhinavdangeti abhinavdangeti changed the title MB-62230 - Add elements to bitmap in a batch. MB-57871, MB-62230: Upgrade to zapx/[email protected] + [email protected] Oct 18, 2024
@abhinavdangeti abhinavdangeti merged commit ab10172 into master Oct 18, 2024
9 checks passed
@abhinavdangeti abhinavdangeti deleted the pre-filter-perf branch October 18, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdangeti abhinavdangeti abhinavdangeti approved these changes

@CascadingRadium CascadingRadium CascadingRadium left review comments

@Thejas-bhat Thejas-bhat Awaiting requested review from Thejas-bhat

@Likith101 Likith101 Awaiting requested review from Likith101

@moshaad7 moshaad7 Awaiting requested review from moshaad7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@metonymic-smokey @abhinavdangeti @CascadingRadium