MB-58134: Skip parsing date time fields with timestamps #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
Thejas-bhat
reviewed
Aug 22, 2023
abhinavdangeti
previously approved these changes
Sep 7, 2023
CascadingRadium
force-pushed
the
MB-58134
branch
from
438ef79
to
274fc9d
Compare
abhinavdangeti
previously approved these changes
Sep 7, 2023
|
merge conflict again 😅 |
Thejas-bhat
approved these changes
Sep 8, 2023
CascadingRadium
added a commit
that referenced
this pull request
Sep 13, 2023
A user can set one of four values as the DateFormat for a DatetimeFieldMapping - "unix_micro" - "unix_sec" - "unix_milli" - "unix_nano" This indicates that the field has a UNIX epoch timestamp in microseconds/seconds/milliseconds/nanoseconds. Such fields should not be parsed with a date time parser since they already contain the timestamp. User can perform date range queries on these fields like normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
MB-58134
Description
A user can set one of four values as the DateFormat for a DatetimeFieldMapping
This indicates that the field has a UNIX epoch timestamp in microseconds/seconds/milliseconds/nanoseconds.
Such fields should not be parsed with a date time parser since they already contain the timestamp.
User can perform date range queries on these fields like normal.