MB-58034: Custom Date Time parsers not being applied on query object #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CascadingRadium
requested review from
abhinavdangeti,
Thejas-bhat,
metonymic-smokey,
Likith101 and
moshaad7
abhinavdangeti
requested changes
Aug 14, 2023
Thejas-bhat
reviewed
Sep 4, 2023
Thejas-bhat
previously approved these changes
Sep 6, 2023
|
the changes look good to me, however i'd strongly recommend waiting for others' review as well. |
Thejas-bhat
reviewed
Sep 6, 2023
abhinavdangeti
approved these changes
Sep 7, 2023
CascadingRadium
added a commit
that referenced
this pull request
Sep 7, 2023
…y object (#1860) - Add a new query DateRangeStringQuery, which takes in the start and end bounds as strings and then parses them using the DateTimeParser set in the DateRangeStringQuery struct, if present and defaults to using the package level QueryDateTimeParser. - ParseQuery, which analyzes a marshalled json to identify the query to run, will now default to DateRangeStringQuery instead, which is preferable because it already has the dates in string format, and unmarshalling to DateRangeQuery will always trigger parsing of the date string with only QueryDateTimeParser, leaving no room for user configuration.
CascadingRadium
added a commit
that referenced
this pull request
Sep 13, 2023
…y object (#1860) - Add a new query DateRangeStringQuery, which takes in the start and end bounds as strings and then parses them using the DateTimeParser set in the DateRangeStringQuery struct, if present and defaults to using the package level QueryDateTimeParser. - ParseQuery, which analyzes a marshalled json to identify the query to run, will now default to DateRangeStringQuery instead, which is preferable because it already has the dates in string format, and unmarshalling to DateRangeQuery will always trigger parsing of the date string with only QueryDateTimeParser, leaving no room for user configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
MB-58034
Description