Simplify iOS development team setup #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
commented
Dec 19, 2023
| target_is_resource_bundle = target.respond_to?(:product_type) && target.product_type == 'com.apple.product-type.bundle' | ||
| target.build_configurations.each do |config| | ||
| if target_is_resource_bundle | ||
| config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO' |
There was a problem hiding this comment.
This is needed to workaround the required code-signing for resource bundle targets.
Initially I wanted to set the team properly but it is not trivial to get the value out of the Developer.xcconfig file.
This is no problem as long as we don't want to submit the example application to the App Store (it will never happen 🙂 )
There was a problem hiding this comment.
Thanks for the comment. Might be worth to add it to the code also 🙂
There was a problem hiding this comment.
That's a great idea, added comment for all workaround here: ed4dfa5
zigavehovec
approved these changes
Dec 19, 2023
| target_is_resource_bundle = target.respond_to?(:product_type) && target.product_type == 'com.apple.product-type.bundle' | ||
| target.build_configurations.each do |config| | ||
| if target_is_resource_bundle | ||
| config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO' |
There was a problem hiding this comment.
Thanks for the comment. Might be worth to add it to the code also 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when trying to run the iOS or tvOS example application on a physical device, it ends up with an error requiring an Apple Development Team to be set in the project file.
This is a change that should not be committed into the repository as the development team can be unique to each contributor.
This causes unnecessary overhead with change management.
This PR changes that to simplify the handling of this via an optional
Developer.xcconfigfile.Changes
.xcconfig) for iOS and tvOS per config (Debug/Release) and configured to optionally import theDeveloper.xcconfigfile.Same way as in our Flutter Player SDK.
CONTRIBUTING.mdwith the instructions for setup.NOTE: if you already have the project checked out, you need to run
yarn example podsfor the Pods project workaround to take effect.Checklist
CHANGELOGentry - not applicable, only example project and documentation changes