Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing subtitle and audio APIs #224

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Add missing subtitle and audio APIs #224

merged 4 commits into from
Sep 7, 2023

Conversation

rolandkakonyi
Copy link
Contributor

Description

This PR extends the Player API to allow fetching the currently selected tracks.

Changes

Introduced the following APIs:

  • Player.getAudioTrack to allow fetching currently selected audio track
  • Player.setAudioTrack to allow fetching currently selected subtitle track

Checklist

  • 🗒 CHANGELOG entry

@rolandkakonyi rolandkakonyi self-assigned this Sep 6, 2023
@rolandkakonyi rolandkakonyi marked this pull request as ready for review September 6, 2023 11:49
zigavehovec
zigavehovec approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@zigavehovec zigavehovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👌

@zigavehovec zigavehovec mentioned this pull request Sep 7, 2023
Merged
1 task
@rolandkakonyi rolandkakonyi merged commit 2b1f11b into development Sep 7, 2023
@rolandkakonyi rolandkakonyi deleted the add-missing-subtitle-and-audio-APIs branch September 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zigavehovec zigavehovec zigavehovec approved these changes

Assignees

@rolandkakonyi rolandkakonyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolandkakonyi @zigavehovec