Add getThumbnail APIs to Player and Source
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
changed the title
getThumbnail APIs to Player and Source
rolandkakonyi
requested review from
matamegger and
zigavehovec
and removed request for
matamegger
zigavehovec
reviewed
Sep 7, 2023
| @ReactMethod | ||
| fun getThumbnail(nativeId: NativeId, time: Double, promise: Promise) { | ||
| uiManager()?.addUIBlock { | ||
| promise.resolve(JsonConverter.fromThumbnail(players[nativeId]?.source?.getThumbnail(time))) |
There was a problem hiding this comment.
Player.getThumbnail has been deprecated in favour of Source.getThumbnail on Android. From my perspective I would be in favour of only wrapping Source.getThumbnail in this PR, but I'm not sure what the state is on iOS, just wanted to point this out.
There was a problem hiding this comment.
@zigavehovec I know about the deprecation on Android but I went for providing both as our Source API is not that rich in the React Native SDK yet. Also we don't support playlist, so only one Source is available at a time.
Co-authored-by: Žiga Vehovec <[email protected]>
zigavehovec
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the
PlayerandSourceAPIs to allow fetching thumbnail information.Changes
Introduced:
Player.getThumbnail(): to fetch thumbnail information for the current sourceSource.getThumbnail(): to fetch thumbnail information for the given sourceChecklist
CHANGELOGentry