fix mutating of query start time for multiple queries #96
Conversation
src/datasource.ts
Outdated
| // create new moment object to not mutate the original grafana object with startOf() to not change | ||
| // the grafana graph as this would change the timeframe for all the following queries | ||
| let queryFrom = moment(range!.from.valueOf()); |
There was a problem hiding this comment.
Wasn't there a reason, why we wanted to mutate original range.from ? I remember, we discuss that for half hour+ in one of techsyncs ... otherwise we would use local let queryFrom from beginning ....
There was a problem hiding this comment.
Yes, the reason was to adjust the timeframe of the graph through modifying the range.from with the startOf() function to be able to display the first datapoint, otherwise it would still be there but outside the graph's boundaries.
I added the range.from() modification again, but only after all the queries were fetched and data was transformed. This way we send the starttimes for all the queries correctly but also adapt the timeframe of the graph to display the first datapoint.
Work: Deletes mutating of grafanas interval start
fromobject. The mutating caused inconsistent behaviour for multiple queries, as the mutating in the first query changed the interval start for all the following queries, which led to different interval Auto calculations for e.g 3 hours.For the 3 hours interval the first query would still return correct
MINUTEinterval, for all the subsequent queries it would returnHOURinterval as the startTime got rounded down and was the above the minuteIntervalLimit.