Feat/AN-4120 playwright e2e tests #93
Conversation
| @@ -60,34 +60,6 @@ jobs: | |||
| version: latest | |||
| args: buildAll | |||
|
|
|||
| - name: Check for E2E | |||
There was a problem hiding this comment.
why changes in github workflow files ? Have they not been generated by grafana plugin generator tool ?
There was a problem hiding this comment.
See answer below.
But good point, instead of having a seperate e2e workflow I will include this here. I will check how the ci file that is generated today with the tool looks like and copy it over.
| e2e-results/ | ||
| **/cypress/videos | ||
| **/cypress/report.json |
There was a problem hiding this comment.
Why is "cypress" mentioned in project files ? I thought new plugin has only playwright ? is this just left over from angular grafana plugin ?
There was a problem hiding this comment.
Cypress is mentioned because grafana just recently deprecated cypress in their plugin development (https://grafana.com/docs/grafana/latest/breaking-changes/breaking-changes-v11-0/#the-grafanae2e-testing-tool-is-deprecated) and back in March when I created the plugin with the generator tool, this generator tool was still using cypress.
| e2e.scenario({ | ||
| describeName: 'Smoke test', | ||
| itName: 'Smoke test', | ||
| scenario: () => { | ||
| e2e.pages.Home.visit(); | ||
| e2e().contains('Welcome to Grafana').should('be.visible'); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
what created this files ?
There was a problem hiding this comment.
The generation tool, see answer above 😊
This reverts commit 146e89d.
Issue: https://bitmovin.atlassian.net/browse/AN-4120
Work: