TYPO3 v10.4 LTS compatibility #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhirdes thanks a lot for your contribution! we will have a look at it soon. |
maechler
reviewed
Jan 29, 2021
| /** | ||
| * @param ObjectManager $objectManager | ||
| */ | ||
| public function __construct(ObjectManager $objectManager) | ||
| public function __construct(ObjectManager $objectManager, RenderingContext $renderingContext) |
There was a problem hiding this comment.
Is the RenderingContext ever used? If it does not serve any purpose, it would be great if you could remove it.
|
@mhirdes Thanks for your contribution! Looks good to me at first glance, I will however have to test it in greater detail and run a few tests. |
|
@mhirdes Thanks again for your contribution! It seems however not to be working as soon as the date column is added to the export. Do you have time to look into this and update the PR? |
Currently not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.