Ask before opening external links #343
Conversation
jarolrod
added
enhancement
jarolrod
force-pushed
the
external-link-warning
branch
from
3a3f8c2
to
e9b6d4a
Compare
|
ACK e9b6d4a |
There was a problem hiding this comment.
tested ACK on Galaxy A13 5G (armv7a) built on WSL Ubuntu 22.04
PR built w/o issues.
nit, the “External Link” text header seems to be a little off center in portrait mode (in landscape it looks centered) see attachment
The adjustment is a mock up made with image manipulation software, no code was altered.
|
Good idea with the column layout for mobile. Small thing, the overlay should have a 1px border around it (neutral 6 color). |
| Layout.fillWidth: true | ||
| header: qsTr("External Link") | ||
| headerBold: true | ||
| headerSize: 24 |
There was a problem hiding this comment.
center: true // Center header text
|
@jarolrod pointed out that this should probably be an application-wide setting. So the first time a user opens an external link, we ask them. If they check the "Don't ask again" option, we don't ask anymore. But they can change this behavior again in the settings. Here's a mock-up for that.
|
There was a problem hiding this comment.
tested ACK on desktop built on both Ubuntus 20.04 & 22.04.
As pointed out by @D33r-Gee, the title of the popup "External Link" is not properly centered (it didn't look right at first sight and checked it with a screen ruler - KRuler, perhaps there's a better tooling), try adding center: true in middleDetail: Header block and re-compiling didn't make any difference for me (event setting it to false doesn't). What reduced the pixels difference (~6 vs ~10 - but to the right direction instead) is adding Layout.alignment: Qt.AlignHCenter in NavigationBar block in ExternalPopup.qml but it's like duplicating what's already specify in NavigationBar.qml (id: middle_detail):
I like the "Don't ask again" toggle switch proposed by @jarolrod and mocked-up by @GBKS.
|
Concept ACK, approach NACK. |
There was a problem hiding this comment.
I've rebuilt this PR on top of #358 using NavBar2 instead and the title of the popup is now more accurately centered.
All usage of this defines the width. This makes the buttons usable in a wider range of situations. We keep the implicitHeight.
jarolrod
force-pushed
the
external-link-warning
branch
from
e9b6d4a
to
726bfa2
Compare
|
rebased over main |
|
This issue has been around for a long time. What is needed to wrap it up? |
Introduces an external link confirm popup window that prompts the user to acknowledge that they really want to visit the external link. This is based off the design file
This contains a menu bar with a title, but is missing the close button. It is also missing the "Don't ask again" button. These require some more conversation and can be addressed in a follow-up.
This deviates from the design file in providing a mobile layout that positions the buttons in a column layout instead of a rowlayout. cc @GBKS @mouxdesign