Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified NavigationBar.qml so text is centered #350

Closed
wants to merge 2 commits into from
Closed

modified NavigationBar.qml so text is centered #350

wants to merge 2 commits into from

Conversation

D33r-Gee
Copy link
Contributor

RE: PR 343

Modified the NavigationBar.qml file so that the "External Link" text would be centered in ExternalPopup.qml file

johnny9
johnny9 reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@johnny9 johnny9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for comments next to the code

@D33r-Gee
Copy link
Contributor Author

D33r-Gee commented Jul 5, 2023

Thanks @johnny9 for your review... Got rid of the comments in the code...

jarolrod
jarolrod reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this, the current approach would currently mess up the layout across different pages in the UI. Pictured below. I'll address this in #343

Screenshot 2023-07-08 at 12 43 21 AM

@D33r-Gee
Copy link
Contributor Author

Makes sense @jarolrod ! Thanks for pointing that out... I'll go ahead and close this one and resume testing on #343

@D33r-Gee D33r-Gee closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarolrod jarolrod jarolrod left review comments

@johnny9 johnny9 johnny9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@D33r-Gee @johnny9 @jarolrod