Use default resolution for viewport_debug example #9666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
changed the title
|
Ping @ickshonpe |
|
Ah I was super confused for a moment, forgot that I even wrote this thing. The changes look fine, though we should probably scrap this eventually and have a proper example that explains the different |
ickshonpe
approved these changes
Sep 1, 2023
|
I guess though there could be a problem with this if the default resolution is changed in the future? |
Agreed.
I suppose we could explicitly define the resolution. |
alice-i-cecile
approved these changes
Sep 2, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective The `viewport_debug` example opens a window that is physically very large. Probably larger than the screen for the majority of machines. ## Solution Remove the custom resolution and adjust the pixel coordinates so that everything lines up. At the default resolution, everything is still whole numbers even without adjusting the viewport coordinates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
viewport_debugexample opens a window that is physically very large. Probably larger than the screen for the majority of machines.Solution
Remove the custom resolution and adjust the pixel coordinates so that everything lines up.
At the default resolution, everything is still whole numbers even without adjusting the viewport coordinates.