Make #[bindless] in ExtendedMaterial actually enable bindless mode.
#16818
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot to set `BINDLESS_SLOT_COUNT` in `ExtendedMaterial`'s implementation of `AsBindGroup`, so it didn't actually become bindless. In fact, it would usually crash with a shader/bind group layout mismatch, because some parts of Bevy's renderer thought that the resulting material was bindless while other parts didn't. This commit corrects the situation. I had to make `BINDLESS_SLOT_COUNT` a function instead of a constant because the `ExtendedMaterial` version needs some logic. Unfortunately, trait methods can't be `const fn`s, so it has to be a runtime function.
pcwalton
added
C-Bug
JMS55
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to set
BINDLESS_SLOT_COUNTinExtendedMaterial's implementation ofAsBindGroup, so it didn't actually become bindless. In fact, it would usually crash with a shader/bind group layout mismatch, because some parts of Bevy's renderer thought that the resulting material was bindless while other parts didn't. This commit corrects the situation.I had to make
BINDLESS_SLOT_COUNTa function instead of a constant because theExtendedMaterialversion needs some logic. Unfortunately, trait methods can't beconst fns, so it has to be a runtime function.