Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clippy lints in benchmarks #16808

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Fix Clippy lints in benchmarks #16808

merged 2 commits into from
Dec 14, 2024
+34 −9

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Dec 13, 2024

Objective

Solution

  • Copied over our Clippy configuration from the root Cargo.toml to benches/Cargo.toml.
  • Fixed any warnings that Clippy emitted.

Testing

  • cd benches && cargo clippy --benches

BD103 added 2 commits December 13, 2024 08:43
@BD103
chore: copy over clippy lints from workspace
3e35d28 
I left out a few, such as `missing_docs` and `unsafe_code`, because they do not apply in this case.
@BD103
fix: clippy lints
392a5ee
@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change C-Benchmarks Stress tests and benchmarks used to measure how fast things are labels Dec 13, 2024
alice-i-cecile
alice-i-cecile approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad about the duplication, but good to fix. Would be nice to have these in the workspace :(

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 14, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 14, 2024
Merged via the queue into bevyengine:main with commit 6178ce9 Dec 14, 2024
37 checks passed
@BD103 BD103 deleted the clippify-benchmarks branch December 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use workspace Clippy lints in benchmarks
2 participants
@BD103 @alice-i-cecile