Introduce support for far culling when using PerspectiveProjection
#16789
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
| @@ -241,18 +241,24 @@ impl Frustum { | |||
|
|
|||
| /// Returns a frustum derived from `clip_from_world`, | |||
| /// but with a custom far plane. | |||
| /// If `far` is `None` behavior is identical to [`Frustum::from_clip_from_world`] | |||
There was a problem hiding this comment.
This seems like the least expectation defying change but not sure it's the best approach?
| let world_from_local = transform.affine(); | ||
| let model_sphere = Sphere { | ||
| center: world_from_local.transform_point3a(model_aabb.center), | ||
| radius: transform.radius_vec3a(model_aabb.half_extents), | ||
| }; | ||
| // Do quick sphere-based frustum culling | ||
| if !frustum.intersects_sphere(&model_sphere, false) { | ||
| if !frustum.intersects_sphere(&model_sphere, use_far_culling) { |
There was a problem hiding this comment.
I thought this would preserve existing behaviour when using the default projections, but maybe I'm misunderstanding as OrthographicProjection previously far culled even though we always passed false here and to intersects_obb?
| let cursor_ray_len = cam_ortho.far - cam_ortho.near; | ||
| let cursor_ray_len = cam_ortho | ||
| .far | ||
| .unwrap_or(OrthographicProjection::DEFAULT_FAR_PLANE) |
There was a problem hiding this comment.
This is definitely wrong and I'm open to suggestions. Would also allow DEFAULT_FAR_PLANE not to be pub.
| let mut projection = PerspectiveProjection::default(); | ||
| projection.far = projection.far.max(size * 10.0); | ||
| projection.far = projection |
There was a problem hiding this comment.
This preserves the existing intention (I think...) but feels odd as the default would be an essentialy infinite far plane anyway?
ptsd
force-pushed
the
feature/optional-far-culling
branch
from
b336c59 to
a555da5
Compare
alice-i-cecile
added
C-Feature
Note
An update of #8205 for 0.15 and with review suggestions.
All credit to @NotoriousENG
Objective
PerspectiveProjectionwould only account for near, left, right, top, and bottom planes with no trivial user facing overridesfar#16746Solution
CameraProjection::far()and it's impls fromf32toOption<f32>fardefaults toOrthographicProjectionandPerspectiveProjectionOrthographicProjection=Some(OrthographicProjection::DEFAULT_FAR_PLANE)Equivalent to existing behaviour of far clipping at
1000.0PerspectiveProjection=NoneEquivalent to existing behaviour of not far clipping at all
Frustum::from_clip_from_world_custom_farto account forfarbecoming optionalbevy_render::view::visibility::check_visibilityto perform far culling when appropriateChangelog
OrthographicProjectionandPerspectiveProjectionwith an explicitfarvalue will need to wrap the value inSomeCameraProjectionwill need updating to account for the changed return type offar()Frustum::from_clip_from_world_custom_farin downstream code will need updating to account for the changed type of thefarparameter