Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Taffy to 0.7 #16780

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Upgrade Taffy to 0.7 #16780

merged 1 commit into from
Dec 12, 2024

Conversation

nicoburns
Copy link
Contributor

Objective

Solution

  • Bump taffy version from 0.6 to 0.7

Testing

  • I have run a couple of examples, but no extensive testing.

@nicoburns
Upgrade Taffy to 0.7
6798db0 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns nicoburns mentioned this pull request Dec 12, 2024
Merged
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 12, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 12, 2024
Open
alice-i-cecile
alice-i-cecile approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this should be an easy small upgrade. Very pleased that the crash fix is in.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 12, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 12, 2024
Merged via the queue into bevyengine:main with commit aa51959 Dec 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@SpecificProtagonist SpecificProtagonist SpecificProtagonist approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Taffy crashes when UI hierarchy modified in specific ways
4 participants
@nicoburns @alice-i-cecile @SpecificProtagonist @BenjaminBrienen