-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event source location tracking #16778
Merged
alice-i-cecile
merged 5 commits into
bevyengine:main
from
SpecificProtagonist:event-src-location-tracking
Dec 12, 2024
Merged
Event source location tracking #16778
alice-i-cecile
merged 5 commits into
bevyengine:main
from
SpecificProtagonist:event-src-location-tracking
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aevyrie
approved these changes
Dec 12, 2024
} | ||
} | ||
|
||
impl PartialReflect for &'static Location<'static> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, nice.
alice-i-cecile
added
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
M-Needs-Release-Note
Work that should be called out in the blog due to impact
labels
Dec 12, 2024
alice-i-cecile
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delightful. I hope we can get all of these shipped for 0.16 :D
alice-i-cecile
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
labels
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
M-Needs-Release-Note
Work that should be called out in the blog due to impact
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16776
Solution
&'static Location
as an opaque typeimpls/std.rs
because other core types are there too. Maybe they should be split out into acore.rs
in another PR.EventId
(behind thetracking_change_detection
feature flag)Testing
Showcase
Migration Guide
SendEvent
, useSendEvent::new()