Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register type BoxShadow #16750

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Register type BoxShadow #16750

merged 1 commit into from
Dec 11, 2024

Conversation

jf908
Copy link
Contributor

@jf908 jf908 commented Dec 10, 2024

Objective

  • Register BoxShadow type for reflection

Testing

  • Tested that box shadow example compiles and runs

Additional

  • It would be nice to have this in 0.15.1

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@IQuick143 IQuick143 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 10, 2024
ickshonpe
ickshonpe approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓 not the first time I forgot this

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 11, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 11, 2024
Merged via the queue into bevyengine:main with commit 62c842c Dec 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jf908 @ickshonpe @alice-i-cecile @IQuick143