Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive Copy on Stopwatch and Timer #16748

Closed
wants to merge 1 commit into from
Closed

derive Copy on Stopwatch and Timer #16748

wants to merge 1 commit into from

Conversation

mirsella
Copy link
Contributor

Objective

Fixes #16743

@IQuick143 IQuick143 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Time Involves time keeping and reporting S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 10, 2024
@alice-i-cecile alice-i-cecile added the X-Contentious There are nontrivial implications that should be thought through label Dec 11, 2024
@alice-i-cecile
Copy link
Member

I'm not convinced we should do this. There's important state stored in here, and accidentally copying it seems like a serious footgun.

@mirsella
Copy link
Contributor Author

mirsella commented Dec 11, 2024 •
edited
Loading

closing this and the issue then (there's more discussion on the issue btw)

@mirsella mirsella closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

derive Copy for Stopwatch/Timer
3 participants
@mirsella @alice-i-cecile @IQuick143