Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RenderDiagnosticsPlugin to diagnostics example #16741

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add RenderDiagnosticsPlugin to diagnostics example #16741

merged 2 commits into from
Dec 10, 2024

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Dec 10, 2024

Improve the example.

@JMS55 JMS55 requested a review from alice-i-cecile December 10, 2024 07:30
@IQuick143 IQuick143 added C-Examples An addition or correction to our examples A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 10, 2024
alice-i-cecile
alice-i-cecile approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as trivial.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 10, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 10, 2024
Merged via the queue into bevyengine:main with commit f3974aa Dec 10, 2024
28 checks passed
BD103 pushed a commit to BD103/bevy that referenced this pull request Dec 10, 2024
@JMS55 @alice-i-cecile @BD103
Add RenderDiagnosticsPlugin to diagnostics example (bevyengine#16741)
9c470a9 
Improve the example.

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JMS55 @alice-i-cecile @IQuick143