Fix crash when component parameters are invalid #16735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
P-Crash
alice-i-cecile
approved these changes
Dec 10, 2024
alice-i-cecile
added
D-Trivial
BD103
pushed a commit
to BD103/bevy
that referenced
this pull request
Dec 10, 2024
# Objective
Fix the following crash when using BRP to insert a malformed component:
```
thread 'main' panicked at /home/purplg/workspaces/evtc-replay/bevy/crates/bevy_remote/src/builtin_methods.rs:926:18:
called `Result::unwrap()` on an `Err` value: Error("invalid type: map, expected f32", line: 0, column: 0)
```
## Solution
Return an error instead of unwrapping.
## Testing
Tested by sending this malformed payload before and after implementing
the fix:
```json
{
"jsonrpc": "2.0",
"id": 0,
"method": "bevy/insert",
"params": {
"entity": 4294967307,
"components": {
"bevy_transform::components::transform::Transform": {
"rotation": [
0.0,
0.0,
0.0,
1.0
],
"scale": [
1.0,
1.0,
1.0
],
"translation": [
{},
0.0,
0.0
]
}
}
}
}
```
After implementing the fix, I receive the following response instead of
a crash:
```json
{
"jsonrpc": "2.0",
"id": 0,
"error": {
"code": -23402,
"message": "bevy_transform::components::transform::Transform is invalid: invalid type: map, expected f32"
}
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix the following crash when using BRP to insert a malformed component:
Solution
Return an error instead of unwrapping.
Testing
Tested by sending this malformed payload before and after implementing the fix:
{ "jsonrpc": "2.0", "id": 0, "method": "bevy/insert", "params": { "entity": 4294967307, "components": { "bevy_transform::components::transform::Transform": { "rotation": [ 0.0, 0.0, 0.0, 1.0 ], "scale": [ 1.0, 1.0, 1.0 ], "translation": [ {}, 0.0, 0.0 ] } } } }After implementing the fix, I receive the following response instead of a crash:
{ "jsonrpc": "2.0", "id": 0, "error": { "code": -23402, "message": "bevy_transform::components::transform::Transform is invalid: invalid type: map, expected f32" } }