Use disqualified for B0001 #16623
Merged
Use disqualified for B0001 #16623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBrienen
approved these changes
Dec 3, 2024
BenjaminBrienen
added
D-Trivial
MrGVSV
reviewed
Dec 3, 2024
| @@ -353,7 +354,7 @@ fn assert_component_access_compatibility( | |||
| return; | |||
| } | |||
| let accesses = conflicts.format_conflict_list(world); | |||
| panic!("error[B0001]: Query<{query_type}, {filter_type}> in system {system_name} accesses component(s){accesses} in a way that conflicts with a previous system parameter. Consider using `Without<T>` to create disjoint Queries or merging conflicting Queries into a `ParamSet`. See: https://bevyengine.org/learn/errors/b0001"); | |||
| panic!("error[B0001]: Query<{}, {}> in system {system_name} accesses component(s){accesses} in a way that conflicts with a previous system parameter. Consider using `Without<T>` to create disjoint Queries or merging conflicting Queries into a `ParamSet`. See: https://bevyengine.org/learn/errors/b0001", ShortName(query_type), ShortName(filter_type)); | |||
There was a problem hiding this comment.
Why do we not shorten the other variables? I think I get system_name, but what about accesses?
Might be worth leaving a comment explaining your reasoning.
There was a problem hiding this comment.
Thanks, I just forgot because that didn't show up in the test case. The access format is now also shortened in system building, which we want.
While I'd prefer not shortening the system name, I don't have a strong preference on this.
There was a problem hiding this comment.
Yeah personally I don't think it should be shortened since sometimes systems share the same or similar names, but scopes according to their module
MrGVSV
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #16553