Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch bevy_mesh to use wgpu-types instead of wgpu #16619

Merged
merged 5 commits into from
Dec 3, 2024
Merged

switch bevy_mesh to use wgpu-types instead of wgpu #16619

merged 5 commits into from
Dec 3, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Dec 3, 2024

Objective

  • dont depend on wgpu if we dont have to

Solution

  • works towards this, but doesnt fully accomplish it. bevy_mesh depends on bevy_image

Testing

  • 3d_scene runs

@mockersf
Copy link
Member

mockersf commented Dec 3, 2024

the doc for the Extrudable trait still mentions wgpu

BD103
BD103 approved these changes Dec 3, 2024
View reviewed changes
crates/bevy_mesh/src/primitives/extrusion.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 3, 2024
@alice-i-cecile @BD103
No crate nit
729f95b 
Co-authored-by: BD103 <[email protected]>
Merged via the queue into bevyengine:main with commit e77efcc Dec 3, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BD103 BD103 BD103 approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @mockersf @BD103 @alice-i-cecile