Rename ArgList::push
methods to with
and add new push
methods which take &mut self
#16567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
ArgList::push
family of methods consumeself
and return a newArgList
which means they can't be used with&mut ArgList
references.It's typical for
push
methods on other existing types to take&mut self
.Solution
Renamed the existing push methods to
with_arg
,with_ref
etc and added newpush
methods which take&mut self
.Migration Guide
Uses of the
ArgList::push
methods should be replaced with thewith
counterpart.