Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bevy_gltf compile without bevy_animation feature #16551

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Make bevy_gltf compile without bevy_animation feature #16551

merged 1 commit into from
Nov 30, 2024

Conversation

mweatherley
Copy link
Contributor

Objective

See title.

Solution

Move bevy_animation import to where it is used.

Testing

Compiled with and without bevy_animation feature enabled.

@mweatherley mweatherley added C-Bug An unexpected or incorrect behavior A-Animation Make things move and change over time P-Compile-Failure A failure to compile Bevy apps A-glTF Related to the glTF 3D scene/model format D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 29, 2024
@mockersf mockersf added this to the 0.15.1 milestone Nov 29, 2024
@mweatherley mweatherley added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 29, 2024
@mockersf mockersf added this pull request to the merge queue Nov 30, 2024
Merged via the queue into bevyengine:main with commit 83b725f Nov 30, 2024
36 checks passed
@kpreid kpreid mentioned this pull request Nov 30, 2024
Closed
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@mweatherley @ecoskey
Make bevy_gltf compile without bevy_animation feature (bevyengine…
222be81 
…#16551)

# Objective

See title.

## Solution

Move `bevy_animation` import to where it is used.

## Testing

Compiled with and without `bevy_animation` feature enabled.
@AlexAegis AlexAegis mentioned this pull request Dec 3, 2024
Open
@dsgallups dsgallups mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasEi NiklasEi NiklasEi approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mweatherley @mockersf @NiklasEi