Reduce iOS cpu usage #16548
Merged
Reduce iOS cpu usage #16548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Performance
|
Prompted by #16541, but not a full fix. See that thread for more information. |
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Nov 29, 2024
That's a second approval. Merging :) |
alice-i-cecile
added
S-Ready-For-Final-Review
extrawurst
approved these changes
Nov 29, 2024
| @@ -34,6 +35,9 @@ fn main() { | |||
| ..default() | |||
| }), | |||
| ) | |||
| // Make the winit loop wait more aggressively when no user input is received | |||
| // This can help reduce cpu usage on mobile devices | |||
There was a problem hiding this comment.
Worth mentioning that this can and is encouraged to use to set desired refresh rate based on the games requirements: low rate fine in a menu and high during interactive gameplay for example
mockersf
added a commit
that referenced
this pull request
Nov 29, 2024
# Objective - Avoid recreating the monitor every loop (temp fix until it's done properly on winit side) - Add a new `WinitSettings` preset for mobile that makes the winit loop wait more and recommend its usage
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective - Avoid recreating the monitor every loop (temp fix until it's done properly on winit side) - Add a new `WinitSettings` preset for mobile that makes the winit loop wait more and recommend its usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
WinitSettingspreset for mobile that makes the winit loop wait more and recommend its usage