Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify inheritance behavior of required components #16546

Merged

Conversation

alice-i-cecile
Copy link
Member

Co-authored by: @BenjaminBrienen

Objective

Fixes #16494. Closes #16539, which this replaces. Suggestions alone weren't enough, so now we have a new PR!

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Nov 28, 2024
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2024
Co-authored-by: Joona Aalto <[email protected]>
Copy link
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely clearer :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 28, 2024
Merged via the queue into bevyengine:main with commit 75c92fb Nov 28, 2024
29 checks passed
@BenjaminBrienen
Copy link
Contributor

Perfect

mockersf pushed a commit that referenced this pull request Nov 29, 2024
Co-authored by: @BenjaminBrienen

# Objective

Fixes #16494. Closes #16539, which this replaces. Suggestions alone
weren't enough, so now we have a new PR!

---------

Co-authored-by: Joona Aalto <[email protected]>
mockersf pushed a commit that referenced this pull request Nov 29, 2024
Co-authored by: @BenjaminBrienen

# Objective

Fixes #16494. Closes #16539, which this replaces. Suggestions alone
weren't enough, so now we have a new PR!

---------

Co-authored-by: Joona Aalto <[email protected]>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
Co-authored by: @BenjaminBrienen

# Objective

Fixes bevyengine#16494. Closes bevyengine#16539, which this replaces. Suggestions alone
weren't enough, so now we have a new PR!

---------

Co-authored-by: Joona Aalto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading docs on duplicate required component constructors
4 participants