-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify inheritance behavior of required components #16546
Merged
alice-i-cecile
merged 3 commits into
bevyengine:main
from
alice-i-cecile:required-components-docs
Nov 28, 2024
Merged
Clarify inheritance behavior of required components #16546
alice-i-cecile
merged 3 commits into
bevyengine:main
from
alice-i-cecile:required-components-docs
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
An addition or correction to our documentation
A-ECS
Entities, components, systems, and events
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Nov 28, 2024
Jondolf
reviewed
Nov 28, 2024
Co-authored-by: Joona Aalto <[email protected]>
mweatherley
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely clearer :)
alice-i-cecile
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Nov 28, 2024
BenjaminBrienen
approved these changes
Nov 28, 2024
Perfect |
mockersf
pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored by: @BenjaminBrienen # Objective Fixes #16494. Closes #16539, which this replaces. Suggestions alone weren't enough, so now we have a new PR! --------- Co-authored-by: Joona Aalto <[email protected]>
mockersf
pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored by: @BenjaminBrienen # Objective Fixes #16494. Closes #16539, which this replaces. Suggestions alone weren't enough, so now we have a new PR! --------- Co-authored-by: Joona Aalto <[email protected]>
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
Co-authored by: @BenjaminBrienen # Objective Fixes bevyengine#16494. Closes bevyengine#16539, which this replaces. Suggestions alone weren't enough, so now we have a new PR! --------- Co-authored-by: Joona Aalto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Docs
An addition or correction to our documentation
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: @BenjaminBrienen
Objective
Fixes #16494. Closes #16539, which this replaces. Suggestions alone weren't enough, so now we have a new PR!