Indices::push(u32)

[stepancheg]

Objective

Making work with Indices struct easier. Currently when building indices in some quick-and-dirty code we need to do matches and handle enum variants.

Solution

Indices::push utility which works transparently with U16 and U32 variants.

Testing

Unit test added.

[stepancheg]

Also, there's silent integer overflow in this code:

bevy/crates/bevy_mesh/src/mesh.rs

Lines 851 to 853 in 74dedb2

	(Indices::U16(i1), Indices::U16(i2)) => {
	i1.extend(i2.iter().map(|i| *i + index_offset as u16));
	}

This code could benefit from changes like this (but not this directly).

[IceSentry]

I'm not sure if I like the auto conversion, but it's not a blocker for me.