Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testbed for 3d #15993

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Testbed for 3d #15993

merged 4 commits into from
Oct 19, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Add tests that cover lights, bloom, gltf and animation
  • Removed examples contributors and load_gltf as they don't contribute additional checks to CI

Testing

  • CI_TESTING_CONFIG=.github/example-run/testbed_3d.ron cargo run --example testbed_3d --features "bevy_ci_testing"

@mockersf mockersf added A-Rendering Drawing game state to the screen A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps labels Oct 18, 2024
@rparrett
Copy link
Contributor

rparrett commented Oct 18, 2024 •
edited
Loading

The animation in the fox scene doesn't seem to start

Nevermind, I see that's intentional. Makes sense with animations not seemingly being deterministic. A comment explaining might be nice.

@mockersf
Copy link
Member Author

Nevermind, I see that's intentional. Makes sense with animations not seemingly being deterministic. A comment explaining might be nice.

Yup, not relying on time makes it easier to be deterministic. I renamed the system to make it more obvious

alice-i-cecile
alice-i-cecile approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this extended, but this is an excellent direction :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 19, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2024
@mockersf
Copy link
Member Author

I've disabled bloom in CI on Windows 🤞

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 19, 2024
Merged via the queue into bevyengine:main with commit 74dedb2 Oct 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @rparrett @alice-i-cecile