-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to wgpu 23 #15988
Upgrade to wgpu 23 #15988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge as long as we're OK to take a dependency on a moving target (I don't think we should). Also maybe the danger of upgrading to a new version close to release (but I understand it fixes some bug).
No need to wrap bind groups in Some() anymore gfx-rs/wgpu#6452 |
Actually that makes it worse... Can't automatically convert between bevy's and wgpu's bind group type...
|
Looks like wgpu 23 is about to release! 🎉 |
This doesn't build on iOS currently according to Francois' testing. |
Just re-triggered a build, here is the failure: https://github.com/TheBevyFlock/bevy-example-runner/actions/runs/11533949819/job/32107445980 |
From last month: gfx-rs/wgpu@fb0cb1e#diff-46fec780a1b7071adf9590bb9d55dfea0f97bd15419ccbe55ee89607fc244335R27 Edit: pushed a commit to attempt to fix this. |
With |
Building now works 🎉 |
Might be worth letting wgpu people know that they should include it in the changelog for wgpu 23. |
Something we can finally now do is use const arrays with dynamic indexes, for e.g. shadow sampling patterns. We should take advantage of this to cleanup a bunch of shader code. |
FYI this also brings CAS atomic operations to Metal. I didn't check if that was the last platform missing them (I expect wasm needs CORS, as with everything atomic due to security reasons, if it even supports CAS at the API level already). |
@tychedelia naga_oil 0.16 has been updated and released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I also tested a bunch of 2d/3d examples on Linux and WebGL and stuff seems to work.
I would like to merge this one quickly and publish a new rc soon after, so get your reviews now! well in the next day or so |
Meshlets worked fine, code looks fine. |
Fixes #15893 --------- Co-authored-by: François Mockers <[email protected]>
Fixes bevyengine#15893 --------- Co-authored-by: François Mockers <[email protected]>
Fixes #15893