Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual improvements to log_layers_ecs example #15949

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Visual improvements to log_layers_ecs example #15949

merged 4 commits into from
Oct 16, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Oct 16, 2024 •
edited
Loading

Objective

Beautify this example, and make adjustments for example visual guidelines.

Also make the example less flaky in CI by removing system info and window entity logs from the visual output.

Solution

  • Add padding to text container
  • Add colors
  • Other small tweaks

Before

Screenshot 2024-10-16 at 7 04 00 AM

After

Screenshot 2024-10-16 at 7 03 41 AM

Testing

cargo run --example log_layer_ecs_improvements

@rparrett rparrett changed the title Visual improvements to log_layers_ecs example Visual improvements to log_layers_ecs example Oct 16, 2024
@rparrett
Bring back bevy's system info logs
f68962e
@rparrett
Revert "Bring back bevy's system info logs"
784b366 
This reverts commit f68962e.

These logs with OS version, window entity id, etc will make the
example visually "flaky" in CI.
@rparrett
Copy link
Contributor Author

rparrett commented Oct 16, 2024 •
edited
Loading

I've gone back and forth on including info level traces from bevy. Open to having my mind changed again there. My thinking is that they make the example "flakier" in CI, are probably not providing any useful signals and distract from the log messages emitted in the example.

@alice-i-cecile
Copy link
Member

IMO don't enable them.

alice-i-cecile
alice-i-cecile approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so much prettier :D Thanks!

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Oct 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 16, 2024
Merged via the queue into bevyengine:main with commit ab79763 Oct 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rparrett @alice-i-cecile