Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExtractComponent::Out #15926

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove ExtractComponent::Out #15926

merged 1 commit into from
Oct 16, 2024

Conversation

akimakinai
Copy link
Contributor

Objective

Solution

  • C -> C::Out

Testing

  • CAS has <ContrastAdaptiveSharpening as ExtractComponent>::Out = (DenoiseCas, CasUniform). Setting its strength to zero correctly removes the effect after this change.

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 15, 2024
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 15, 2024
MiniaczQ
MiniaczQ approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@MiniaczQ MiniaczQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't familiar with the trait in last PR my bad,
this looks appropriate

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 15, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 15, 2024
Merged via the queue into bevyengine:main with commit c78886e Oct 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiniaczQ MiniaczQ MiniaczQ approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
4 participants
@akimakinai @tychedelia @MiniaczQ @alice-i-cecile