Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshot comparison: prepare macos folder in the expected format by upload-artifact action #15911

Merged

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 14, 2024

Objective

Solution

  • Try to prepare it like the upload-artifact action expects it

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Oct 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 14, 2024
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 14, 2024
Merged via the queue into bevyengine:main with commit 8c0fcf0 Oct 14, 2024
30 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
# Objective

- Used the wrong variable to set metadata
- new fixes after #15911

## Solution

- Use the right one
- Also keep a reference to the original PR when there's one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants