Fix deferred rendering #15656
Merged
Fix deferred rendering #15656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoff3r
added
C-Bug
mockersf
approved these changes
Oct 4, 2024
alice-i-cecile
approved these changes
Oct 4, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #15525
The deferred and mesh pipelines tonemapping LUT bindings were accidentally out of sync, breaking deferred rendering.
As noted in the issue it's still broken on wasm due to hitting a texture limit.
Solution
Add constants for these instead of hardcoding them.
Testing
Test with
cargo run --example deferred_renderingand see it works, run the same on main and see it crash.