Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Adreno 642L crash #14937

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

sampettersson
Copy link
Contributor

Objective

The Android example on Adreno 642L currently crashes on startup.

Previous PRs #14176 and #13323 have adressed this specific crash occurring on some Adreno GPUs, that fix works as it should but isn't applied when to the GPU name contains a suffix like in the case of 642L.

Solution

  • Amending the logic to filter out any parts of the GPU name not containing digits thus enabling the fix on 642L.

Testing

  • Ran the Android example on a Nothing Phone 1. Before this change it crashed, after it works as intended.

@Olle-Lukowski Olle-Lukowski added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash O-Android Specific to the Android mobile operating system S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 27, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the comment and the clear function name. Annoyed about the workaround, but what can you do.

@mockersf mockersf added this pull request to the merge queue Aug 27, 2024
Merged via the queue into bevyengine:main with commit 5f061ea Aug 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen O-Android Specific to the Android mobile operating system P-Crash A sudden unexpected crash S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants