Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepass batch #13943

Merged
merged 4 commits into from
Jul 14, 2024
Merged

Fix prepass batch #13943

merged 4 commits into from
Jul 14, 2024

Conversation

re0312
Copy link
Contributor

@re0312 re0312 commented Jun 20, 2024

Objective

  • After Allow Mesh-related queue phase systems to parallelize #11804 , The queue_prepass_material_meshes function is now executed in parallel with other queue_* systems. This optimization introduced a potential issue where mesh_instance.should_batch() could return false in queue_prepass_material_meshes due to an unset material_bind_group_id.

@re0312 re0312 marked this pull request as ready for review June 20, 2024 13:44
@janhohenheim janhohenheim added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 21, 2024
@Elabajaba Elabajaba self-requested a review June 21, 2024 23:15
Elabajaba
Elabajaba approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@Elabajaba Elabajaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct, though I didn't go and check drawcall counts to see if I could reproduce the broken batching.

Tested the SSAO example (normal and depth prepass) and deferred_rendering and both of them still worked.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 14, 2024
Merged via the queue into bevyengine:main with commit 3b23aa0 Jul 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Elabajaba Elabajaba Elabajaba approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@re0312 @Elabajaba @alice-i-cecile @janhohenheim