rename touchpad to gesture, and add new gestures #13660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Input
alice-i-cecile
added
C-Feature
alice-i-cecile
removed
the
M-Needs-Release-Note
alice-i-cecile
approved these changes
Jun 3, 2024
|
there's a PR to add some of them to Wayland rust-windowing/winit#3656, and I started looking for Android |
ramirezmike
reviewed
Jun 4, 2024
crates/bevy_window/src/window.rs
Outdated
| /// - Only used on iOS. | ||
| /// - On macOS, they are recognized by default and can't be disabled. | ||
| pub recognize_doubletap_gesture: bool, | ||
| /// Sets whether this window recognize [`PanGesture`], with a number of fingers between the first value and the last. |
There was a problem hiding this comment.
This might be my ignorance, what does number of fingers between the first value and the last mean?
recognize_pan_gesture: Some((0, 5)) would this be like a whole hand?
There was a problem hiding this comment.
it's the number of fingers you use at the same time for the gesture, so (0, 5) would detect pan gesture with 0, 1, 2, 3, 4 or 5 fingers.
Co-authored-by: mike <[email protected]>
ramirezmike
approved these changes
Jun 4, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
ios-rotation.mp4
Migration Guide
TouchpadMagnifyhas been renamed toPinchGestureTouchpadRotatehas been renamed toRotationGesture